Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta-private-cluster-update-variant] Enable image streaming at cluster level #1360

Closed
jawnsy opened this issue Aug 18, 2022 · 11 comments · Fixed by #1696
Closed

[beta-private-cluster-update-variant] Enable image streaming at cluster level #1360

jawnsy opened this issue Aug 18, 2022 · 11 comments · Fixed by #1696
Labels
enhancement New feature or request

Comments

@jawnsy
Copy link

jawnsy commented Aug 18, 2022

TL;DR

The documentation describes the enable_gcfs flag for node pools, but this does not seem to enable the cluster-level image streaming option

Terraform Resources

No response

Detailed design

No response

Additional information

We are defining our node pools like this, according to the documentation, with the enable_gcfs = true flag:

    {
      name               = "pool"
      preemptible        = false
      spot               = true
      enable_secure_boot = true
      enable_gcfs        = true
      machine_type       = "t2d-standard-4"
      min_count          = 0
      max_count          = 10
      max_surge          = 4
      image_type         = "COS_CONTAINERD"
    },

However, after the cluster is created, the Image Streaming option is not enabled in the UI:

image

@jawnsy jawnsy added the enhancement New feature or request label Aug 18, 2022
@bharathkkb
Copy link
Member

Thanks for the report! Does enable_gcfs show up in the plan at all? I am wondering if this is a bug in the module or the provider.

@lauraseidler
Copy link
Contributor

We're having the same "issue" - but I don't think it's a bug.

Image streaming can be enabled on clusters and/or on node pools, with the cluster setting being inherited to its node pools, unless the setting is overridden on node pool level.

AFAICS, this module so far only supports enabling image streaming on node pool level, so it would make sense to me that image streaming on cluster level is shown as disabled. I would expect that if the option is added to also enable it on cluster level, this would show also in the UI. I don't see image streaming in the UI for node pools, but it shows up correctly as enabled when getting it via gcloud container node-pools describe [...].

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 22, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2022
@themanifold
Copy link
Contributor

This shouldn't be closed, it's not fixed yet.

@apeabody apeabody removed the Stale label Jan 23, 2023
@apeabody apeabody reopened this Jan 23, 2023
@snigdhasambitak
Copy link

snigdhasambitak commented Mar 8, 2023

Yes, image streaming on the cluster level is a necessary feature. So, if possible this could be an enhancement to the module

@github-actions
Copy link

github-actions bot commented May 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 7, 2023
@jawnsy
Copy link
Author

jawnsy commented May 8, 2023

I believe this is still an open issue

@github-actions github-actions bot removed the Stale label May 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 7, 2023
@jawnsy
Copy link
Author

jawnsy commented Jul 8, 2023

I believe this is still an open issue

@github-actions github-actions bot removed the Stale label Jul 8, 2023
lauraseidler added a commit to lauraseidler/terraform-google-kubernetes-engine that referenced this issue Jul 23, 2023
Could previously be set manually via console/`gcloud` - if this was
enabled, `enable_gcfs` must be set to `true` with this update, otherwise
image streaming will be disabled.

Fixes terraform-google-modules#1360
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 7, 2023
@jawnsy
Copy link
Author

jawnsy commented Sep 8, 2023

I think this issue is still valid, not stale.

Thanks to @lauraseidler for opening #1696!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
6 participants