Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu nodepool with gpu_sharing_strategy & max_shared_clients_per_gpu not possible #1506

Closed
kdngit12 opened this issue Dec 19, 2022 · 8 comments · Fixed by #1874
Closed

gpu nodepool with gpu_sharing_strategy & max_shared_clients_per_gpu not possible #1506

kdngit12 opened this issue Dec 19, 2022 · 8 comments · Fixed by #1874
Labels
enhancement New feature or request

Comments

@kdngit12
Copy link

TL;DR

gpu nodepool with gpu_sharing_config including gpu_sharing_strategy & max_shared_clients_per_gpu currently cannot be created as these parameters cannot be passed/configured like the one from resource "google_container_node_pool"

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool

...
guest_accelerator {
      type  = "nvidia-tesla-a100"
      gpu_partition_size = "1g.5gb"
      count = 1
      gpu_sharing_config {
        gpu_sharing_strategy = "TIME_SHARING"
        max_shared_clients_per_gpu = 2
      }
}	
...

Detailed design

No response

Additional information

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/NodeConfig
@kdngit12 kdngit12 added the enhancement New feature or request label Dec 19, 2022
@s04
Copy link

s04 commented Jan 19, 2023

Bump! Hoping this get's exposed soon :)

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 20, 2023
@nthnb
Copy link

nthnb commented Mar 23, 2023

Bump!

@github-actions github-actions bot removed the Stale label Mar 23, 2023
@abursavich abursavich mentioned this issue Mar 28, 2023
Closed
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
luisferreira32 pushed a commit to luisferreira32/terraform-google-kubernetes-engine that referenced this issue Jun 22, 2023
@luismferreira
feat: add gpu_sharing_config to node_pools 2
d61ab12 
Opinionated expose of gpu_sharing_config. Fixes terraform-google-modules#1506, alternative
to terraform-google-modules#1599.
@luisferreira32 luisferreira32 mentioned this issue Jun 22, 2023
Closed
luisferreira32 added a commit to luisferreira32/terraform-google-kubernetes-engine that referenced this issue Jun 22, 2023
@luisferreira32
feat: add gpu_sharing_config to node_pools 2
7c819ab 
Opinionated expose of gpu_sharing_config. Fixes terraform-google-modules#1506, alternative to terraform-google-modules#1599.
luisferreira32 added a commit to luisferreira32/terraform-google-kubernetes-engine that referenced this issue Jun 22, 2023
@luisferreira32
feat: add gpu_sharing_config to node_pools 2
450339f 
Opinionated expose of gpu_sharing_config. Fixes terraform-google-modules#1506, alternative to terraform-google-modules#1599.
Let the google_container_node_pool do the error handling.
@rsaget
Copy link

rsaget commented Oct 25, 2023

Hey, any news on this ?

@LotemAm
Copy link

LotemAm commented Feb 8, 2024

Bumping

@jimgus jimgus mentioned this issue Feb 13, 2024
Merged
@apeabody apeabody removed the Stale label Feb 16, 2024
@apeabody apeabody reopened this Feb 16, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Apr 16, 2024
@em-le-ts
Copy link

Hey, any news for this feature?
Thanks

@github-actions github-actions bot removed the Stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
7 participants
@apeabody @nthnb @LotemAm @kdngit12 @s04 @em-le-ts @rsaget