-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firewall rule name conflicts if var.name
is too long since it'll be truncated.
#1527
Labels
bug
Something isn't working
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
bump |
NissesSenap
added a commit
to NissesSenap/terraform-google-kubernetes-engine
that referenced
this issue
May 25, 2023
This to be able to have longer and unique names. The firewall API supports 64 charters Solves terraform-google-modules#1527
NissesSenap
added a commit
to NissesSenap/terraform-google-kubernetes-engine
that referenced
this issue
May 25, 2023
This to be able to have longer and unique names. The firewall API supports 64 charters Solves terraform-google-modules#1527 Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
@FuyuanChu I created a PR to solve this. Let's see if it gets merged. |
NissesSenap
added a commit
to NissesSenap/terraform-google-kubernetes-engine
that referenced
this issue
Jun 13, 2023
This to be able to have longer and unique names. The firewall API supports 64 charters Solves terraform-google-modules#1527 Signed-off-by: Edvin Norling <edvin.norling@kognic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
Firewall rule name conflicts if
var.name
is too long since it'll be truncated."gke-${substr(var.name, 0, min(25, length(var.name)))}-webhooks"
Expected behavior
Generate unique firewall rule names regardless of the length of
var.name
Observed behavior
If I have two clusters with a long name variable such as
var.name = a-cluster-running-in-region-hk
var.name = a-cluster-running-in-region-sg
The firewall rule name generated for webhook will be the same since
var.name
will be truncated.Terraform Configuration
Nothing special.
Just create two clusters with long names that share the same 25 characters.
And set
add_master_webhook_firewall_rules
totrue
Terraform Version
Additional information
Error log
The text was updated successfully, but these errors were encountered: