Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: enable auto repair and upgrade with cluster autoscaling #1530

Merged
merged 7 commits into from
Jan 31, 2023
Merged

fix!: enable auto repair and upgrade with cluster autoscaling #1530

merged 7 commits into from
Jan 31, 2023

Conversation

naveen230
Copy link
Contributor

Fixes #1504

@naveen230 naveen230 requested review from a team, Jberlinsky and ericyz as code owners January 15, 2023 17:42
@google-cla
Copy link

google-cla bot commented Jan 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@naveen230 naveen230 marked this pull request as draft January 15, 2023 17:57
@naveen230 naveen230 force-pushed the fix-enable-nap-auto-upgrade-repair branch from 2441085 to fbc21f4 Compare January 15, 2023 19:58
@naveen230 naveen230 marked this pull request as ready for review January 15, 2023 20:15
@naveen230 naveen230 marked this pull request as draft January 16, 2023 14:46
@naveen230
fix: Enable auto upgrade/repair with cluster autoscaling
7464b27 
- Use lookup function and set defaults
@naveen230 naveen230 marked this pull request as ready for review January 16, 2023 15:02
@comment-bot-dev
Copy link

@naveen230
Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @naveen230

@bharathkkb bharathkkb changed the title fix: enable auto repair and upgrade with cluster autoscaling fix!: enable auto repair and upgrade with cluster autoscaling Jan 31, 2023
@bharathkkb bharathkkb merged commit d59542c into terraform-google-modules:master Jan 31, 2023
@release-please release-please bot mentioned this pull request Jan 31, 2023
Merged
@jarpat jarpat mentioned this pull request May 11, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@naveen230 @Tolsee @bharathkkb
fix!: enable auto repair and upgrade with cluster autoscaling (terraf…
f982181 
…orm-google-modules#1530)

Co-authored-by: Tolsee <tolsee3@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto_upgrade / auto_repair not updated in cluster_autoscaling of Node Auto-Provisioning
4 participants
@naveen230 @comment-bot-dev @bharathkkb @Tolsee