-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: (IAC-997) (IAC-995) Update viya4-iac-gcp Providers, Modules, & Dependencies and Patch Security Issues #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riragh
approved these changes
May 11, 2023
thpang
reviewed
May 11, 2023
dhoucgitter
reviewed
May 11, 2023
dhoucgitter
reviewed
May 11, 2023
dhoucgitter
reviewed
May 11, 2023
thpang
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dhoucgitter
approved these changes
May 15, 2023
This was referenced May 18, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the viya4-iac-gcp Providers, Modules, & Dependencies and Patch Security Issues
Below is notes and changes that I made as I upgraded the modules/providers.
Providers
hashicorp/google & hashicorp/google-beta
hashicorp/kubernetes
hashicorp/local
hashicorp/template
templatefile
function since 2020, now would be a good time to make the swap before it's officially removed.templatefile
is already used in the OSS repo, so use that a referencehashicorp/random
hashicorp/null
hashicorp/external
hashicorp/time
Modules
module.gke
cluster_autoscaling
line here in main.tf. It now requires the attributesauto_repair
&auto_upgrade
and their values, similarly to how we added a default forgpu_resources
during the last module updatevar.kubernetes_channel
here, so we can adopt the same behavior forcluster_autoscaling
module.postgresql
module.sql_proxy_sa
module.nat_address
module.cloud_nat
As part of updating the modules we are also going to set
When creating a postgres instances so we will no longer be blocked by pgadmin & the SharedServices database when trying to delete the Postgres resource.
Fixes #47
Tests
See internal ticket for additional details and security report.