-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[private-cluster-update-variant] Module does not allow to update node pool labels without pool recration #1695
Labels
bug
Something isn't working
Comments
We're running into the same issue - I'll test if removing the keeper is enough, and will open a PR |
lauraseidler
added a commit
to lauraseidler/terraform-google-kubernetes-engine
that referenced
this issue
Jul 24, 2023
Will cause node pools to be re-created on update, unless remote state of the `random_id` resources is manually modified to reflect the new keepers. Fixes terraform-google-modules#1695
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Not stale, this is still an open issue |
lauraseidler
added a commit
to lauraseidler/terraform-google-kubernetes-engine
that referenced
this issue
Oct 12, 2023
Will cause node pools to be re-created on update, unless remote state of the `random_id` resources is manually modified to reflect the new keepers. Fixes terraform-google-modules#1695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
Modules private-cluster-update-variant and beta-private-cluster-update-variant still forces node pools to be recreated, while since 4.48.0 labels allowed to be updated in-place.
Can it be fixed by just removing labels block from keepers?
Expected behavior
Updating lables for node pool updates it in-place.
Observed behavior
Updating labels in module forces random_id to recreate and it leads to node_pool be recreated too.
Terraform Configuration
Terraform Version
Additional information
No response
The text was updated successfully, but these errors were encountered: