Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for default_max_nodes_per_host #170

Closed
algermissen opened this issue Jun 13, 2019 · 3 comments
Closed

Support for default_max_nodes_per_host #170

algermissen opened this issue Jun 13, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@algermissen
Copy link

Hi,
I would like to add default_max_nodes_per_host parameter. I have created a branch for this: https://github.com/algermissen/terraform-google-kubernetes-engine/tree/add-default-max-pods-per-node

However, I had to hard-code the beta-provisioner and this prevents me from raising a PR.

Can you give any advice how you would like to have it integrated? Currently it is dependent on another condition and adding to that will make everything less clear.

Please provide direction and I'll adjust and raise PR.

@aaron-lane aaron-lane added the enhancement New feature or request label Jun 14, 2019
@aaron-lane
Copy link
Contributor

Hi @algermissen. Thank you for your interest in contributing!

We are considering a redesign of this module in the near future which may require use of the beta provider for both public and private clusters, so this is not an unprecedented change. Please propose your change and we will try to include it when the new version is released.

@algermissen
Copy link
Author

Hi @aaron-lane PR is here: #174

@morgante
Copy link
Contributor

Fixed by #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants