Add default_max_pods_per_node and max_pods_per_node #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the max_pods_per_node setting on pool level was not taken from the provided pool configuration.
algermissen
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
|
Hi @algermissen! Thank you for the contribution. I apologize for the delay in reviewing this. #124 introduced submodules for public and private clusters with beta features. Are you available to update this branch accordingly? |
|
Replaced by #220. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
default_max_pods_per_nodeat the cluster level and formax_pods_per_nodeat the pool level.Merging this will also explicitly set the provider to
google-betaand drop the private/public cluster conditional in the regional cluster (original code commented).