Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodules w/ beta Istio and CloudRun addons #124

Merged
merged 12 commits into from
Jun 19, 2019
Merged

Conversation

ocervell
Copy link
Contributor

@ocervell ocervell commented Mar 27, 2019

This PR adds two new submodules:

  • beta-public-cluster: Creates a public GKE cluster with beta features enabled.
  • beta-private-cluster: Creates a private GKE cluster with beta features enabled.

This PR supports Istio and CloudRun GKE addons beta features. Other PRs are planned to add support for all other beta features.

TODO:

  • Example for beta-public-cluster
  • Example for beta-private-cluster

@ocervell ocervell mentioned this pull request Mar 27, 2019
@ocervell ocervell changed the title [WIP] Submodules w/ beta Istio and CloudRun addons Submodules w/ beta Istio and CloudRun addons May 9, 2019
@ocervell
Copy link
Contributor Author

ocervell commented May 9, 2019

Fixes #107

@aaron-lane aaron-lane added the enhancement New feature or request label May 27, 2019
@thefirstofthe300
Copy link
Contributor

Any update on this PR? I am in need of application secrets encryption so I'd like to base a PR to add this feature off this PR if this is the route we're going.

@morgante
Copy link
Contributor

morgante commented Jun 3, 2019

@ocervell Can you rebase on master?

Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase against master.

@chrislovecnm
Copy link
Contributor

Is support for this possible without these changes? We have VPA and binary auth now as well. Also istion will soon have configurations to pass in.

@morgante
Copy link
Contributor

@chrislovecnm We will either need to merge this PR or a separate one to support these new optional addons.

@ocervell Are you able to pick this up or should we hand it off?

@ocervell
Copy link
Contributor Author

@aaron-lane @morgante rebased against master

@ocervell
Copy link
Contributor Author

@chrislovecnm we'll merge this and add support for VPA and binary auth, Istio config in a further PR (feel free to attack it :))

@chrislovecnm
Copy link
Contributor

Woop!

@morgante morgante requested a review from aaron-lane June 14, 2019 17:28
@dmyerscough
Copy link

Any ideas when this will be merged in?

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as a start.

Remaining tasks:

@morgante morgante merged commit be765c9 into master Jun 19, 2019
@aaron-lane aaron-lane deleted the feature/beta-cluster branch June 27, 2019 20:08
@aaron-lane aaron-lane mentioned this pull request Nov 16, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…-modules/feature/beta-cluster

Submodules w/ beta Istio and CloudRun addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants