-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submodules w/ beta Istio and CloudRun addons #124
Conversation
Fixes #107 |
Any update on this PR? I am in need of application secrets encryption so I'd like to base a PR to add this feature off this PR if this is the route we're going. |
@ocervell Can you rebase on master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase against master.
Is support for this possible without these changes? We have VPA and binary auth now as well. Also istion will soon have configurations to pass in. |
@chrislovecnm We will either need to merge this PR or a separate one to support these new optional addons. @ocervell Are you able to pick this up or should we hand it off? |
@aaron-lane @morgante rebased against master |
@chrislovecnm we'll merge this and add support for VPA and binary auth, Istio config in a further PR (feel free to attack it :)) |
Woop! |
Any ideas when this will be merged in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as a start.
Remaining tasks:
- Integrate Istio and other submodules
- Remove all beta features from main module - Ensure that GA modules don't depend on beta functionality #181
- Add testing for beta module - Add tests for beta submodules/examples #180
…-modules/feature/beta-cluster Submodules w/ beta Istio and CloudRun addons
This PR adds two new submodules:
beta-public-cluster
: Creates a public GKE cluster with beta features enabled.beta-private-cluster
: Creates a private GKE cluster with beta features enabled.This PR supports Istio and CloudRun GKE addons beta features. Other PRs are planned to add support for all other beta features.
TODO: