Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that GA modules don't depend on beta functionality #181

Closed
morgante opened this issue Jun 19, 2019 · 3 comments · Fixed by #228
Closed

Ensure that GA modules don't depend on beta functionality #181

morgante opened this issue Jun 19, 2019 · 3 comments · Fixed by #228
Assignees
Labels
enhancement New feature or request

Comments

@morgante
Copy link
Contributor

We should remove the beta provider from the testing config for the non-beta modules and ensure that it's not required.

@aaron-lane aaron-lane added the enhancement New feature or request label Jun 19, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 3, 2019
…nd on beta functionality

 terraform-google-modules#181

 * Remove provider `google-beta`
 * Remove `gcloud beta`-cli commands from kitchen tests
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 3, 2019
…nd on beta functionality

 terraform-google-modules#181

 * Remove provider `google-beta`
 * Remove `gcloud beta`-cli commands from kitchen tests
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 3, 2019
…nd on beta functionality

 terraform-google-modules#181

 * Remove provider `google-beta`
 * Remove `gcloud beta`-cli commands from kitchen tests
@kopachevsky
Copy link
Contributor

kopachevsky commented Aug 9, 2019

@aaron-lane @morgante examples/node_pool uses node_config taint property, that in Beta

node_pools_taints = {
all = [
{
key = "all-pools-example"
value = true
effect = "PREFER_NO_SCHEDULE"
},
]

How do we proceed with this example and corespondent test? create new node_pool that uses modules/beta_public, keep one node_pool but move it to beta fully or just remove taints part from example/test?

@nick4fake
Copy link
Contributor

@kopachevsky I suggest simply pointing that example to the beta submodule
@morgante what should we do with the fact of taints missing from non-beta provider?

@morgante
Copy link
Contributor Author

We can move that example to point to the beta provider.

morgante added a commit that referenced this issue Aug 28, 2019
Fix for Ensure that GA modules don't depend on beta functionality #181
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Beta functionality removed fully from public and private cluster modules and related exampled.
As long node_pool example used taints that in beta, it switched to public-cluster-beta module from root one.

 * Fixes terraform-google-modules#181
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Fix for Ensure that GA modules don't depend on beta functionality terraform-google-modules#181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants