-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that GA modules don't depend on beta functionality #181
Comments
…nd on beta functionality terraform-google-modules#181 * Remove provider `google-beta` * Remove `gcloud beta`-cli commands from kitchen tests
…nd on beta functionality terraform-google-modules#181 * Remove provider `google-beta` * Remove `gcloud beta`-cli commands from kitchen tests
…nd on beta functionality terraform-google-modules#181 * Remove provider `google-beta` * Remove `gcloud beta`-cli commands from kitchen tests
@aaron-lane @morgante examples/node_pool uses node_config taint property, that in Beta terraform-google-kubernetes-engine/examples/node_pool/main.tf Lines 92 to 99 in 1ce3e62
How do we proceed with this example and corespondent test? create new node_pool that uses modules/beta_public, keep one node_pool but move it to beta fully or just remove taints part from example/test? |
@kopachevsky I suggest simply pointing that example to the beta submodule |
We can move that example to point to the beta provider. |
Fix for Ensure that GA modules don't depend on beta functionality #181
Beta functionality removed fully from public and private cluster modules and related exampled. As long node_pool example used taints that in beta, it switched to public-cluster-beta module from root one. * Fixes terraform-google-modules#181
Fix for Ensure that GA modules don't depend on beta functionality terraform-google-modules#181
We should remove the beta provider from the testing config for the non-beta modules and ensure that it's not required.
The text was updated successfully, but these errors were encountered: