-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitoring_enable_managed_prometheus field not working in v27.0.0 #1706
Comments
The way dynamic "monitoring_config" {
for_each = length(var.monitoring_enabled_components) > 0 || var.monitoring_enable_managed_prometheus ? [1] : []
content {
enable_components = length(var.monitoring_enabled_components) > 0 ? var.monitoring_enabled_components : []
dynamic "managed_prometheus" {
for_each = var.monitoring_enable_managed_prometheus ? [1] : []
content {
enabled = var.monitoring_enable_managed_prometheus
}
}
}
} |
For_each being set as false will prevent it for executing enabled=true or false. |
Upvoting this as we've just noticed it applying to all our new and upgraded clusters despite the |
Any news about this? We are using private cluster module and it's impossible to disable managed Prometheus. |
+1 on this, I still cannot manage to disable it |
+1 seeing the same in 28.0.0 |
the fix in 29.0.0 |
The fix doesn't seem to work for me:
The plan contains a lot of noise (due to #1773 as I would be upgrading from
|
Because of some bad conditions in module you have to specify at least one component if you want to disable prometheus:
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This isn't correct. I faced it recently using |
Issue still exist in 30.0.0 |
@ericyz looks like users still have some trouble configuring this. Could you PTAL? |
Thanks for reopening this issue. I am wondering if the fix can be back ported to the previous released versions (we use v26.0.0). |
Issue still exist in v31.0.0 |
TL;DR
Inspite of setting "monitoring_enable_managed_prometheus" variable equal to false on version v27.0.0 of this terraform module
"Managed Service for Prometheus" in gcp still enabled
gke version 1.27.4-gke.900
Expected behavior
Managed Service for Prometheus should be disabled.
Observed behavior
Managed Service for Prometheus is enabled.
Terraform Configuration
Terraform Version
Additional information
https://cloud.google.com/stackdriver/docs/managed-prometheus/setup-managed#enable-mgdcoll-gke
The text was updated successfully, but these errors were encountered: