Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not ignore "mesh_id" label on "google_container_cluster" resource #1836

Merged

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jan 4, 2024

Fixes #1671
Relates to #1061

According to the documentation, mesh_id label is supposed to be set explicitly on the GKE cluster:

However, right now this label is ignored by terraform, so it's not possible to set it using IaC.
This PR fixes that issue and removes mesh_id label from the ignore_changes list

@apeabody
Copy link
Contributor

apeabody commented Jan 8, 2024

/gcbrun

1 similar comment
@apeabody
Copy link
Contributor

apeabody commented Jan 9, 2024

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @legal90!

Thanks for the review @ferrarimarco!

@apeabody apeabody merged commit 95641a6 into terraform-google-modules:master Jan 18, 2024
4 checks passed
@legal90 legal90 deleted the fix-mesh-id-label-ignore branch February 1, 2024 22:17
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asm labelling docs unclear due to ignored var
3 participants