-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant storage viewer to created service accounts #229
Comments
Correct, this module doesn't include the storage viewer role by default (not all customers use GCR). We could possibly add a flag to add that role. For now, you can also add it yourself:
|
Thanks, that solved the issue, but have an option could be nice :) |
Agreed. I suggest we add a boolean variable |
* Added `sa_grant_gcs_access` variable to grant `roles/storage.objectViewer` to created SA
* Added `sa_grant_gcs_access` variable to grant `roles/storage.objectViewer` to created SA
* Added `sa_grant_gcs_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
* Added `sa_grant_gcs_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
* Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
* Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
* Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
* Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
I am creating a testing gke cluster using this module, everything works, but after the cluster is being created, docker fails to pull images from gcr private repository, because the service account created by this modules doesn't has the roles/storage.objectViewer
In the sa.tf I don't see nothing for the needed role:
The text was updated successfully, but these errors were encountered: