Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region variable should be optional for zonal clusters #235

Closed
morgante opened this issue Aug 14, 2019 · 0 comments · Fixed by #247
Closed

Region variable should be optional for zonal clusters #235

morgante opened this issue Aug 14, 2019 · 0 comments · Fixed by #247
Assignees
@paulpalamarchuk
Labels
enhancement New feature or request

Comments

@morgante
Copy link
Contributor

morgante commented Aug 14, 2019 •
edited

Currently, the 'region' variable is always required: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/variables.tf#L41

We should only require this be specified for regional clusters (not for zonal clusters).
@aaron-lane aaron-lane added the enhancement New feature or request label Aug 16, 2019
@paulpalamarchuk paulpalamarchuk self-assigned this Aug 23, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Aug 27, 2019
@paulpalamarchuk
Changed region variable
6acf099 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
@paulpalamarchuk paulpalamarchuk mentioned this issue Aug 27, 2019
Merged
@aaron-lane aaron-lane changed the title Regional variable should be optional for zonal clusters Region variable should be optional for zonal clusters Sep 10, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Sep 11, 2019
@paulpalamarchuk
Changed region variable
f692693 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Sep 26, 2019
@paulpalamarchuk
Changed region variable
4344b0a 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 10, 2019
@paulpalamarchuk
Changed region variable
3f0cf1b 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 12, 2019
@paulpalamarchuk
Changed region variable
c4bf4cf 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@paulpalamarchuk
Changed region variable
8e526b1 
 * `region` variable became optional for zonal clusters (Fixes terraform-google-modules#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulpalamarchuk paulpalamarchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed region variable paulpalamarchuk/terraform-google-kubernetes-engine
3 participants
@morgante @aaron-lane @paulpalamarchuk