Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node pool autoscaling opt out #249

Closed
Dev25 opened this issue Aug 27, 2019 · 1 comment
Closed

Allow node pool autoscaling opt out #249

Dev25 opened this issue Aug 27, 2019 · 1 comment

Comments

@Dev25
Copy link
Contributor

Dev25 commented Aug 27, 2019

I would like to get a quick consensus before submitting the PR since there is a related prior issue: #83

We now use dynamic blocks quite a bit in this module, i would like to add a autoscaling bool flag (default is true) for node-pools to allow users to disable autoscaling on specific node pools if required.

This allows users to have whatever nodepool structure they want and the small benefit of not cluttering the autoscaling status (kubectl -n kube-system get cm cluster-autoscaler-status -oyaml) with nodepools that are fixed.

@morgante
Copy link
Contributor

Thanks for checking in!

Now that this can be solved with conditional blocks, I'm on board with making autoscaling optional (but enabled by default).

We should still use min_count as the variable controlling the number of nodes, but the autoscaling flag would drop the autoscaling block and add node_count param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants