Add opt out for node pool autoscaling #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev25
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
approved these changes
Aug 28, 2019
|
@Dev25 Indeed, we don't currently document the node_pools variable. I think it'd be good if we added an additional table in the README under the inputs table. |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Add opt out for node pool autoscaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#249
Allow users to set
autoscaling = falsein the node pools map variable to toggle autoscaling on that specific node pool. By default and to keep existing behaviour the default value is true for autoscaling.I've noticed we don't really document the possible keys in the node_pools map, do we want to start doing that and if so what's the preferred way?