-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically update labels for sandboxed node pools #252
Comments
Working on it. |
@morgante This label cannot be set for the node pool.
Tested with provider "google-beta", version |
@paulpalamarchuk Without this label, are we seeing a diff on labels post-apply? |
@morgante Yes. TF state don't have that label |
Got it. Please focus on moving the resource block (and adding a test). I will take care of the label issue. |
Shall I create test (fixtures, etc.) for the "sandbox" config? |
Just add the flag + test to an existing suite such as |
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
* Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240) * Created test for sandbox (Fix terraform-google-modules#252) * Updated docker image version
This is a follow up to #240.
Based on hashicorp/terraform-provider-google#4210, if sandboxing is enabled then the control plain will add this label to the cluster automatically:
sandbox.gke.io/runtime" = "gvisor
.This causes a permadiff. We should fix this by automatically injecting that label into the config if the sandbox flag is
true
on the module.The text was updated successfully, but these errors were encountered: