Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically update labels for sandboxed node pools #252

Closed
morgante opened this issue Aug 28, 2019 · 7 comments · Fixed by #286
Closed

Automatically update labels for sandboxed node pools #252

morgante opened this issue Aug 28, 2019 · 7 comments · Fixed by #286
Assignees
@paulpalamarchuk
Labels
bug Something isn't working

Comments

@morgante
Copy link
Contributor

This is a follow up to #240.

Based on hashicorp/terraform-provider-google#4210, if sandboxing is enabled then the control plain will add this label to the cluster automatically: sandbox.gke.io/runtime" = "gvisor.

This causes a permadiff. We should fix this by automatically injecting that label into the config if the sandbox flag is true on the module.
@morgante morgante changed the title Automatically update taints for sandboxes Automatically update labels for sandboxed node pools Aug 28, 2019
@aaron-lane aaron-lane added the bug Something isn't working label Aug 29, 2019
@nick4fake
Copy link
Contributor

Working on it.

@paulpalamarchuk
Copy link
Contributor

paulpalamarchuk commented Oct 11, 2019 •
edited

@morgante This label cannot be set for the node pool.
Error:

Error: error creating NodePool: googleapi: Error 400: Node label "sandbox.gke.io/runtime" is reserved for gke sandbox., badRequest

Tested with provider "google-beta", version 2.17.0

@morgante
Copy link
Contributor Author

@paulpalamarchuk Without this label, are we seeing a diff on labels post-apply?

@paulpalamarchuk
Copy link
Contributor

@morgante Yes. TF state don't have that label

@morgante
Copy link
Contributor Author

Got it. Please focus on moving the resource block (and adding a test).

I will take care of the label issue.

@paulpalamarchuk
Copy link
Contributor

Shall I create test (fixtures, etc.) for the "sandbox" config?

@morgante
Copy link
Contributor Author

Just add the flag + test to an existing suite such as simple_regional_beta.

paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
79d8b65 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
@paulpalamarchuk paulpalamarchuk mentioned this issue Oct 14, 2019
Closed
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
6420311 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
8764620 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
c61ed6b 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
6e8ad97 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 14, 2019
@paulpalamarchuk
Add test for sandbox
eda0c98 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Add test for sandbox
daaf03f 
 * Moved `sanbox_config` to `node_pool` resouce (Fix terraform-google-modules#240)
 * Created test for sandbox (Fix terraform-google-modules#252)
 * Updated docker image version
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Created test for sandbox (Fix terraform-google-modules#252)
c829328
@paulpalamarchuk paulpalamarchuk mentioned this issue Oct 18, 2019
Merged
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Created test for sandbox (Fix terraform-google-modules#252)
a401a2e
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 21, 2019
@paulpalamarchuk
Created test for sandbox (Fix terraform-google-modules#252)
e90d20b
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@paulpalamarchuk
Created test for sandbox (Fix terraform-google-modules#252)
6164046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulpalamarchuk paulpalamarchuk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@nick4fake @morgante @aaron-lane @paulpalamarchuk