Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var to allow a pre-generated SSH key to be passed to the ACM module #329

Closed
thecodejunkie opened this issue Nov 15, 2019 · 4 comments · Fixed by #346
Closed

Add var to allow a pre-generated SSH key to be passed to the ACM module #329

thecodejunkie opened this issue Nov 15, 2019 · 4 comments · Fixed by #346
Assignees
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@thecodejunkie
Copy link

The current implementation of the ACM module only allows you to generate a new SSH key or not to create the git-secret at all. Ideally it should be possible to pass in an ssh_key variable as well, so you have the ability to pass in a pre-generated key.

Something like this would be nice functionality

  • Was ssh_key provided?
    • Yes - > Use it
    • No -> Is create_ssh_key set to true?
      • Yes -> Generate one
      • No -> Do nothing
@morgante
Copy link
Contributor

Would you want this to be the actual private key (contents) or a file path? I'm thinking contents would be more flexible (since you can always grab them from a file using file() in your config.

@thecodejunkie
Copy link
Author

Oh sorry, forgot to mention that. Yes, I think the ideal would be to pass in the content of the file since it provides more flexibility in where the config originates from

@morgante morgante added enhancement New feature or request triaged Scoped and ready for work labels Nov 18, 2019
@thecodejunkie
Copy link
Author

@morgante what're your thoughts about completely replacing the create_ssh_key variable (and corresponding usage of tls_private_key) with a ssh_key variable? I feel that by introducing the ability to pass in a key, it should not be the responsibility for the ACM module to generate one for you. Either you grab your key from whatever location you wish or you make use of tls_private_key yourself and pass the output as the value to the ssh_key parameter?

I'm happy to take a stab at such a change if you want me to?

@morgante
Copy link
Contributor

I'd prefer to not remove the create_ssh_key functionality. We can provide ssh_key as an additional option, but for testing/bootstrapping I think the in-module creation is helpful.

@paulpalamarchuk paulpalamarchuk self-assigned this Nov 21, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Nov 22, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Dec 2, 2019
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
3 participants