Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for preemptible nodes #36

Closed
lantier opened this issue Dec 4, 2018 · 3 comments
Closed

Support for preemptible nodes #36

lantier opened this issue Dec 4, 2018 · 3 comments

Comments

@lantier
Copy link
Contributor

lantier commented Dec 4, 2018

Is it in the roadmap for support?
I think this can solve without minor issues:

node_config {
    preemptible    = "${lookup(var.node_pools[count.index], "preemptible", false)}"
}
@morgante
Copy link
Contributor

morgante commented Dec 4, 2018

Yeah, we can definitely add this. PR's welcome as well!

carter-bradford added a commit to precocity-labs/terraform-google-kubernetes-engine that referenced this issue Dec 9, 2018
morgante added a commit that referenced this issue Dec 14, 2018
@czka
Copy link

czka commented Dec 18, 2018

Code changes should not be accepted without respective doc updates. Only accidentally I have learned that preemptible nodes are already supported in this module. I have almost wasted my time trying to add an already existing feature. Now I'm wasting it writing this comment.

@morgante
Copy link
Contributor

@czka Point well taken. As an immediate measure I added it to the usage example (f057964). Longer term, we need to improve documentation of the node_pools variable (#45).

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
…pport-preemptible-nodes

Added support for preemptible nodes terraform-google-modules#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants