Enable Surge Upgrades (Beta) #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev25
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
reviewed
Jan 7, 2020
There was a problem hiding this comment.
Thanks for the addition, and I agree this is probably a best practice. However, it is technically a backwards-incompatible breaking change, so there are two options:
- Introduce the flags, but default to off/disabled.
- Include this change in the next major breaking change.
|
That's reasonable, i suggest we go for 2 rather then adding a flag now and then defaulting that to yes in a future breaking change anyway. I assume we can get the for_each PR #257 merged soon and since that requires a state migration it would be a breaking change? |
|
Yes, #257 would also be a breaking change. |
|
@Dev25 Could you resolve conflicts? I'm hoping to release a new version this week (with a few breaking changes). |
|
Awesome, done + updated the README node pool var section too @morgante |
kri5
pushed a commit
to kri5/terraform-google-kubernetes-engine
that referenced
this pull request
Jan 27, 2020
…le (Beta) (terraform-google-modules#394) BREAKING CHANGE: beta clusters now have surge upgrades turned on by default. This behavior can be tuned using the max_surge and max_unavailable inputs.
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…le (Beta) (terraform-google-modules#394) BREAKING CHANGE: beta clusters now have surge upgrades turned on by default. This behavior can be tuned using the max_surge and max_unavailable inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Surge upgrades for all beta node-pools, using the current default values set by GKE.
imo it should be a best practice/enforced by this module, but i can also add a disable flag if we want the option to disable it?
GKE Doc
GKE API Doc