Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private-cluster does not allow changing default_max_pods_per_node #435

Closed
chanuka-techo opened this issue Feb 18, 2020 · 2 comments · Fixed by #439
Closed

private-cluster does not allow changing default_max_pods_per_node #435

chanuka-techo opened this issue Feb 18, 2020 · 2 comments · Fixed by #439
Assignees
@ChandranshuRao14
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@chanuka-techo
Copy link

This is more of a question than an issue. Is there any reason for limiting the private-cluster default_max_pods_per_node to 110, which is the default?
@bharathkkb
Copy link
Member

Previously it was in beta and hence only supported on the beta clusters
I think we can add support now as this is now GA
GoogleCloudPlatform/magic-modules#2429

@morgante
Copy link
Contributor

morgante commented Feb 19, 2020 •
edited

Yup looks like we can roll this out for all (remove the beta condition on the flag).

@morgante morgante added enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work labels Feb 19, 2020
@ChandranshuRao14 ChandranshuRao14 mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChandranshuRao14 ChandranshuRao14

Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollout default_max_pods_per_node to all ChandranshuRao14/terraform-google-kubernetes-engine
4 participants
@morgante @bharathkkb @ChandranshuRao14 @chanuka-techo