max_pods_per_node is GA now. #2429

nat-henderson · 2019-10-04T20:29:01Z

Release Note Template for Downstream PRs (will be copied)

`container`: moved `default_max_pods_per_node` to ga.

modular-magician · 2019-10-04T20:37:39Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 648a451.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1235
depends: hashicorp/terraform-provider-google#4621

modular-magician · 2019-10-04T20:49:46Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ef7dfc9.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-10-04T21:12:44Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 905e4fc.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

rileykarson · 2019-10-04T21:20:48Z

third_party/terraform/tests/resource_container_node_pool_test.go.erb

@@ -28,7 +28,6 @@ func TestAccContainerNodePool_basic(t *testing.T) {
 				ResourceName:      "google_container_node_pool.np",
 				ImportState:       true,
 				ImportStateVerify: true,
-				ImportStateVerifyIgnore: []string{"max_pods_per_node"},


Good catch on these- it looks like there are a bunch more, do you mind getting them too?

modular-magician · 2019-10-07T19:32:45Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 84c252d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-10-07T22:13:30Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 491b416.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

nat-henderson · 2019-10-07T22:17:59Z

Running the container tests on the downstream now.

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

morgante · 2020-02-19T23:12:46Z

From the docs, it looks like the node pool setting (max_pods_per_node) is still only on the the beta provider: https://www.terraform.io/docs/providers/google/r/container_node_pool.html#max_pods_per_node

Can we also add that to the GA provider?

bharathkkb · 2020-02-20T23:17:58Z

Looking at the code, it looks like it should be GA as the line doesnt seem to be version guarded and docs are not updated

magic-modules/third_party/terraform/resources/resource_container_node_pool.go.erb

Line 99 in a9cabe8

"max_pods_per_node": &schema.Schema{

nat-henderson · 2020-02-21T18:36:07Z

Yes, it was added in hashicorp/terraform-provider-google#4621.

nat-henderson · 2020-02-21T18:36:20Z

Ah, but the docs are handwritten, I see...

nat-henderson added the changelog: enhancement label Oct 4, 2019

googlebot added the cla: yes label Oct 4, 2019

nat-henderson mentioned this pull request Oct 4, 2019

default_max_pods_per_node , max_pods_per_node is GA already should not be only beta hashicorp/terraform-provider-google#4617

Closed

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Oct 4, 2019

rileykarson mentioned this pull request Oct 4, 2019

Enable GKE pods_per_node flags in GA #2377

Closed

nat-henderson requested review from rileykarson and removed request for rileykarson October 4, 2019 20:53

rileykarson approved these changes Oct 4, 2019

View reviewed changes

modular-magician added the automerged label Oct 8, 2019

nat-henderson and others added 7 commits October 8, 2019 00:01

max_pods_per_node is GA now.

5e3e91d

one more function to move.

13179d1

Also remove from node_pool.

47b7b5e

also remove from tests.

c6b4460

remove max_pods_per_node exclude from remaining tests.

cac5874

Add back in relevant test.

33a472a

Update tracked submodules -> HEAD on Tue Oct 8 00:01:54 UTC 2019

606281a

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.

modular-magician force-pushed the max-pods-ga branch from 491b416 to 606281a Compare October 8, 2019 00:02

modular-magician merged commit 6fde5d4 into master Oct 8, 2019

nat-henderson deleted the max-pods-ga branch October 8, 2019 17:57

ewolak-sq mentioned this pull request Oct 11, 2019

default_max_pods_per_node is out of beta hashicorp/terraform-provider-google#4466

Closed

bharathkkb mentioned this pull request Feb 19, 2020

private-cluster does not allow changing default_max_pods_per_node terraform-google-modules/terraform-google-kubernetes-engine#435

Closed

nat-henderson mentioned this pull request Feb 21, 2020

Update docs - max_pods_per_node has been GA for a while. #3158

Merged

This was referenced Feb 21, 2020

Update docs - max_pods_per_node has been GA for a while. hashicorp/terraform-provider-google#5735

Merged

Update docs - max_pods_per_node has been GA for a while. hashicorp/terraform-provider-google-beta#1787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

max_pods_per_node is GA now. #2429

max_pods_per_node is GA now. #2429

nat-henderson commented Oct 4, 2019

modular-magician commented Oct 4, 2019

modular-magician commented Oct 4, 2019

modular-magician commented Oct 4, 2019

rileykarson Oct 4, 2019

nat-henderson Oct 7, 2019

modular-magician commented Oct 7, 2019

modular-magician commented Oct 7, 2019

nat-henderson commented Oct 7, 2019

morgante commented Feb 19, 2020

bharathkkb commented Feb 20, 2020 •

edited

Loading

nat-henderson commented Feb 21, 2020

nat-henderson commented Feb 21, 2020

max_pods_per_node is GA now. #2429

max_pods_per_node is GA now. #2429

Conversation

nat-henderson commented Oct 4, 2019

modular-magician commented Oct 4, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 4, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 4, 2019

Pull request statuses

New Pull Requests

rileykarson Oct 4, 2019

Choose a reason for hiding this comment

nat-henderson Oct 7, 2019

Choose a reason for hiding this comment

modular-magician commented Oct 7, 2019

Pull request statuses

New Pull Requests

modular-magician commented Oct 7, 2019

Pull request statuses

New Pull Requests

nat-henderson commented Oct 7, 2019

morgante commented Feb 19, 2020

bharathkkb commented Feb 20, 2020 • edited Loading

nat-henderson commented Feb 21, 2020

nat-henderson commented Feb 21, 2020

bharathkkb commented Feb 20, 2020 •

edited

Loading