-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GKE pods_per_node flags in GA #2377
Enable GKE pods_per_node flags in GA #2377
Conversation
As far as I can tell from the documentation at https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr, these features are now GA, so they should be made available in the "google" provider, not just the "google-beta" provider.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is missing some code that needs to be included. I commented all the ones I noticed.
@@ -961,11 +961,9 @@ func resourceContainerClusterCreate(d *schema.ResourceData, meta interface{}) er | |||
ResourceLabels: expandStringMap(d, "resource_labels"), | |||
} | |||
|
|||
<% unless version == 'ga' -%> | |||
if v, ok := d.GetOk("default_max_pods_per_node"); ok { | |||
cluster.DefaultMaxPodsConstraint = expandDefaultMaxPodsConstraint(v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function called here will need to be made available as well.
magic-modules/third_party/terraform/resources/resource_container_cluster.go.erb
Lines 1209 to 1211 in a3a434c
if cluster.DefaultMaxPodsConstraint != nil { | |
d.Set("default_max_pods_per_node", cluster.DefaultMaxPodsConstraint.MaxPodsPerNode) | |
} |
flatten
function as well.
And this test (I think all the other features are GA) + the config it links at the bottom of the test file.
magic-modules/third_party/terraform/tests/resource_container_cluster_test.go.erb
Line 1406 in a3a434c
func TestAccContainerCluster_withFlexiblePodCIDR(t *testing.T) { |
@ndmckinley I saw you just opened #2429, assigning review to you. |
Ah, shoot, yeah, I just did essentially the same thing, didn't see your PR. :( I missed doing the same thing in node_pool, though, so I'll make that change in my PR. Thanks. |
As far as I can tell from the documentation at
https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr,
these features are now GA, so they should be made available in the
"google" provider, not just the "google-beta" provider.
Release Note Template for Downstream PRs (will be copied)