Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zonal bug #474

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Fix zonal bug #474

merged 4 commits into from
Apr 7, 2020

Conversation

jmymy
Copy link
Contributor

@jmymy jmymy commented Apr 3, 2020

The Safer modules support regional and zonal clusters. However, the zones variable is never passed so the config errors when setting regional = false

#449

Jonathan Meyers added 3 commits April 2, 2020 14:36
Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>
Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>
Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>
@bharathkkb
Copy link
Member

LGTM

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@morgante morgante merged commit 7660b51 into terraform-google-modules:master Apr 7, 2020
@jmymy jmymy deleted the fix-zonal-bug branch April 8, 2020 03:05
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…aform-google-modules#474)

* passed zones to the parent module

Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>

* module update

* put back vars

Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>

* autogen

Signed-off-by: Jonathan Meyers <jonathan@cybrary.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants