Nodelocal dnscache

[jmymy]

Added support for NodeLocal DNSCache addon that came in provider version 3.14.0

#428

https://github.com/terraform-providers/terraform-provider-google/releases/tag/v3.14.0

[jmymy]

the error im getting locally is
Error: Error running command 'PATH=/workspace/test/fixtures/simple_zonal/.terraform/modules/example.acm.acm_operator/terraform-google-gcloud-0.5.1/cache/42adaccd/google-cloud-sdk/bin:$PATH ../../../modules/acm/scripts/kubectl_wrapper.sh https://<crud> = kubectl apply -f /workspace/acm.yaml ': exit status 1. Output: -d, --decode decode data error: the path "/workspace/acm.yaml" does not exist

gsutil cp gs://config-management-release/released/1.3.0/config-management-operator.yaml config-management-operator.yaml
AccessDeniedException: 403 jonathan@ does not have storage.objects.list access to config-management-release.

[bharathkkb]

Thanks for the contribution @jmymy
You can run individual test suites by following this, that particular test that is failing requires access to a GCS bucket and hence it is failing.

In addition, may I propose enabling this in one of the existing tests and making sure that it passes?
We can enable it in a beta fixture like this one and add a small test here
something like "dnsCacheConfig" => {foo:bar}

[bharathkkb]

LGTM

[jmymy]

The addition of
dns_cache_config { enabled = var.dns_cache }

even if set to disable (when the existing cluster has it disabled), is appearing as a destructive action now when bumping the module version on existing clusters. I'm wondering if we should wrap logic around that and only include the block only when set to true?

need to do some more digging

FYI @bharathkkb @morgante

[morgante]

@jmymy Please check the discussion/solution here - #428 (comment)

[jmymy]

@jmymy Please check the discussion/solution here - #428 (comment)

doh.. i literally pulled up that issue before commenting here. Sorry for the noise.