Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with dynamic service account variable #5

Closed
morgante opened this issue Sep 12, 2018 · 4 comments
Closed

Fails with dynamic service account variable #5

morgante opened this issue Sep 12, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@morgante
Copy link
Contributor

This config fails:

  node_pools = [
    {
      name            = "pool-01"
      machine_type    = "n1-standard-1"
      min_count       = 2
      max_count       = 2
      disk_size_gb    = 30
      disk_type       = "pd-standard"
      image_type      = "COS"
      auto_repair     = false
      auto_upgrade    = false
      service_account = "${google_service_account.cluster_nodes.email}"
    },
  ]

While this config works:

  node_pools = [
    {
      name            = "pool-01"
      machine_type    = "n1-standard-1"
      min_count       = 2
      max_count       = 2
      disk_size_gb    = 30
      disk_type       = "pd-standard"
      image_type      = "COS"
      auto_repair     = false
      auto_upgrade    = false
      service_account = "${google_service_account.cluster_nodes.email}"
    },
  ]
@ocervell
Copy link
Contributor

+1 any update on this ?

@aaron-lane aaron-lane added the bug Something isn't working label May 27, 2019
@aaron-lane
Copy link
Contributor

@morgante was the second example intended to have a different value for service_account?

@ingwarr
Copy link
Contributor

ingwarr commented Jun 26, 2019

@aaron-lane I need additional clarification for this issue, I have insufficient information to reproduce and/or fix it

@morgante
Copy link
Contributor Author

create is now available to generate the service account in the module.

mmontan added a commit to mmontan/terraform-google-kubernetes-engine that referenced this issue Sep 30, 2019
# This is the 1st commit message:

Initial definition of a Safer Cluster module.

# This is the commit message terraform-google-modules#2:

Add a sample for using the safer-cluster module.

# This is the commit message terraform-google-modules#3:

Add a test kitchen instance

# This is the commit message terraform-google-modules#4:

Formatting TF files.

# This is the commit message terraform-google-modules#5:

Add a test for the safer-cluster module

# This is the commit message terraform-google-modules#6:

Additional fixes
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants