Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grant_registry_access variable unused in safer-cluster #508

Closed
MartinPetkov opened this issue May 5, 2020 · 0 comments
Closed

grant_registry_access variable unused in safer-cluster #508

MartinPetkov opened this issue May 5, 2020 · 0 comments

Comments

@MartinPetkov
Copy link
Contributor

In safer-cluster, the grant_registry_access variable is exposed but unused and set to true:

terraform-google-kubernetes-engine/modules/safer-cluster/main.tf

Line 94 in 5791ac1

grant_registry_access = true

The variable should either be used and default to true, or removed.
MartinPetkov added a commit to MartinPetkov/terraform-google-kubernetes-engine that referenced this issue May 5, 2020
@MartinPetkov
Use the grant_registry_access variable in safer-cluster
8e0b1eb 
Issue: terraform-google-modules#508
@MartinPetkov MartinPetkov mentioned this issue May 5, 2020
Merged
morgante pushed a commit that referenced this issue May 5, 2020
@MartinPetkov
feat: Expose the grant_registry_access variable in safer-cluster (#509)
0961613 
Issue: #508
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@MartinPetkov
feat: Expose the grant_registry_access variable in safer-cluster (ter…
81d167d 
…raform-google-modules#509)

Issue: terraform-google-modules#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinPetkov