-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not a valid Win32 application error on a Windows machine #630
not a valid Win32 application error on a Windows machine #630
Comments
I think this should be a fix in the gcloud module and we should be able to fix it by adding a conditional count in that external data resource which respects gcloud module |
@morgante reopening this so we can track the migration for GKE module from current gcloud |
Would you mind providing some information around a timeline for when this fix will be integrated into this module? As mentioned by OP, this completely blocks usage of this module on windows. |
@CMorton737 If you exclude the |
@morgante what do you mean by excluding stud_domains ? |
@Loudsi Try setting |
@morgante I think the problem was gcloud was not respecting @Loudsi could you try with |
@morgante @bharathkkb thanks for your support, indeed adding skip_provisioners = true in the module config do not work. |
Hi @Loudsi |
The version 11.1.0 still use terraform-google-modules/gcloud/google 1.4.1 for:
AND
|
Hi @wer-mathurin module "gke" {
source = "github.com/terraform-google-modules/terraform-google-kubernetes-engine"
.
.
} |
I got the latest version and tested by setting skip_provisioners = true in examples/safer-cluster. That's because there is the following in the beta-private-cluster module:
Definition of the flag:
It does seem like an abuse of the flag intended for something else. What if someone needs to run this on windows and does want to skip all local-exec provisioners? |
@jakubpawlowski |
Changing the condition indeed disables a lot of local-exec provisioners in gcloud/google module so that may be the right thing to do |
On my side when not specifying the flag everything work as expected. |
@jakubpawlowski fixed via #669 |
Thanks - it's working fine now with the flag set to true. Looking forward to having this fixed released now :) |
Hello! We're getting a similar error on version 31.1 when
|
I'm trying to run example from examples/safer_cluster folder and getting the following error:
This seems to be caused by this commit;
65172de Marshall Ford* 18/06/2020 03:18 fix: Use gcloud module for scripts, closes #401 (#404)
In particular going from local-exec provisioner:
to using "terraform-google-modules/gcloud/google" (and now: "terraform-google-modules/gcloud/google//modules/kubectl-wrapper") which has this line:
It runs even when I set skip_provisioners = true
This completely blocks usage of this module on Windows machines.
My terraform version (although it should not matter):
The text was updated successfully, but these errors were encountered: