Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcloud executable requirement, removal of jq #401

Closed
marshallford opened this issue Jan 14, 2020 · 1 comment · Fixed by #404
Closed

gcloud executable requirement, removal of jq #401

marshallford opened this issue Jan 14, 2020 · 1 comment · Fixed by #404

Comments

@marshallford
Copy link
Contributor

Hello,

I'd like to discuss the possibility of using the gcloud module as a replacement for the wait-for-cluster.sh script. Perhaps a solution similar to this PR: terraform-google-modules/terraform-google-project-factory#343.

I am a TFE customer and would like to avoid opting out of the "wait for cluster" feature via skip_provisioners. Thoughts? I'm thinking you could avoid requiring jq by doing something like this:

gcloud container clusters list --filter=name:<CLUSTER_NAME> --format="value(status)"

If this of interest I would be more than happy to put a PR together.

Thanks.
@morgante
Copy link
Contributor

Yes, I'd definitely like to move to using the gcloud module for this.

Note that the gcloud module does include jq. Happy to look at a PR for this though, either way.

@rohitgabrieleit rohitgabrieleit mentioned this issue Mar 4, 2020
Closed
@bharathkkb bharathkkb mentioned this issue May 14, 2020
Closed
@marshallford marshallford mentioned this issue May 14, 2020
Merged
morgante pushed a commit that referenced this issue Jun 18, 2020
@marshallford
fix: Use gcloud module for scripts, closes #401 (#404)
65172de
@jakubpawlowski jakubpawlowski mentioned this issue Aug 13, 2020
Closed
@bharathkkb bharathkkb mentioned this issue Jan 7, 2021
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@marshallford
fix: Use gcloud module for scripts, closes terraform-google-modules#401…
54ee9a1 
… (terraform-google-modules#404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use gcloud module for scripts, closes #401
2 participants
@marshallford @morgante