feat: Hub submodule - add option to use existing service account to register clusters. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-pharaoh
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
approved these changes
Sep 18, 2020
modules/hub/README.md
Outdated
| @@ -41,7 +41,9 @@ To deploy this config: | |||
| | gke\_hub\_sa\_name | Name for the GKE Hub SA stored as a secret `creds-gcp` in the `gke-connect` namespace. | string | `"gke-hub-sa"` | no | | |||
| | location | The location (zone or region) this cluster has been created in. | string | n/a | yes | | |||
| | project\_id | The project in which the resource belongs. | string | n/a | yes | | |||
| | sa\_private\_key | Private key for service account. Required only if `use_existing_sa` is set to `true`. | string | `"null"` | no | | |||
There was a problem hiding this comment.
Should we call out the fact that this should be base64 encoded?
There was a problem hiding this comment.
Yes. That is a good idea.
bharathkkb
changed the title
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…egister clusters. (terraform-google-modules#678) * use existing service account * count. use index * format and docs * add encoded to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.