-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hub submodule - add option to use existing service account to register clusters. #678
feat: Hub submodule - add option to use existing service account to register clusters. #678
Conversation
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR!
modules/hub/README.md
Outdated
@@ -41,7 +41,9 @@ To deploy this config: | |||
| gke\_hub\_sa\_name | Name for the GKE Hub SA stored as a secret `creds-gcp` in the `gke-connect` namespace. | string | `"gke-hub-sa"` | no | | |||
| location | The location (zone or region) this cluster has been created in. | string | n/a | yes | | |||
| project\_id | The project in which the resource belongs. | string | n/a | yes | | |||
| sa\_private\_key | Private key for service account. Required only if `use_existing_sa` is set to `true`. | string | `"null"` | no | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call out the fact that this should be base64 encoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That is a good idea.
…egister clusters. (terraform-google-modules#678) * use existing service account * count. use index * format and docs * add encoded to docs
No description provided.