fix: removing gcloud_skip_download variable #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko7460
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
morgante
suggested changes
Oct 15, 2020
There was a problem hiding this comment.
Please make sure to remove from all submodules as well - https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/search?q=skip_download
|
@morgante should we also add a sentence for discoverability linking to gcloud module on how to use the env var? If we just include it in the upgrade guide, new users may not discover this is possible. |
@bharathkkb Yes I think a note in the README would be a good idea. |
marko7460
force-pushed
the
fix/remove_skip_gcloud
branch
from
de812cc
to
5e86276
Compare
marko7460
commented
Oct 15, 2020
marko7460
force-pushed
the
fix/remove_skip_gcloud
branch
from
5e86276
to
62fab6e
Compare
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #674