Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Terraform v0.14 #754

Closed
cooperbenson-qz opened this issue Dec 3, 2020 · 4 comments
Closed

Support Terraform v0.14 #754

cooperbenson-qz opened this issue Dec 3, 2020 · 4 comments
Labels
good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work

Comments

@cooperbenson-qz
Copy link

cooperbenson-qz commented Dec 3, 2020

Hashicorp released v0.14 yesterday and this module is preventing us from updating. Looking at the errors it seems like only the version constraint prevents it from working with Terraform v0.14 (there's also a small syntax warning)

Warning: Version constraints inside provider configuration blocks are deprecated

  on .terraform/modules/web.gke/modules/beta-private-cluster-update-variant/auth.tf line 30, in provider "kubernetes":
  30:   version                = "~> 1.10, != 1.11.0"

Terraform 0.13 and earlier allowed provider version constraints inside the
provider configuration block, but that is now deprecated and will be removed
in a future version of Terraform. To silence this warning, move the provider
version constraint into the required_providers block.


Error: Unsupported Terraform Core version

  on .terraform/modules/web.gke/modules/beta-private-cluster-update-variant/versions.tf line 18, in terraform:
  18:   required_version = ">=0.12.6, <0.14"

Module module.web.module.gke (from
terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster-update-variant)
does not support Terraform version 0.14.0. To proceed, either choose another
supported Terraform version or update this version constraint. Version
constraints are normally set for good reason, so updating the constraint may
lead to other errors or unexpected behavior.
@bharathkkb
Copy link
Member

Hi @cooperbenson-qz
Happy to accept a PR to relax this. Example PR terraform-google-modules/terraform-google-project-factory#505

@bharathkkb bharathkkb added good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work labels Dec 3, 2020
@bharathkkb
Copy link
Member

fixed via #757

@cpumanaz
Copy link

cpumanaz commented Dec 5, 2020

@bharathkkb What is the lag time before the module update is available:
https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google/latest

Just wondering if this is CI, or if there is another step that needs to be accomplished.

Thanks.

@bharathkkb
Copy link
Member

Hi @cpumanaz
It is automatically picked up by the registry after a release. I just cut a release for v12.2 that has this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants