-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(terraform): support terraform 0.14 by bumping version constraint to v0.15 #505
Conversation
I think we should just remove the upper version constraint |
@bouk I agree. What stopped me was the other PR referenced above and that it already exists as a constraint. Terraform 0.13.X+ generates version constraints automatically for the minimum versions and not the maximum versions. It's best practice to only specify a minimum version constraint as per the docs: https://www.terraform.io/docs/configuration/version-constraints.html#terraform-core-and-provider-versions. Must be a reason a maximum version is specified here? If not happy to commit an additional commit to remove completely. |
@tomchinery feel free to remove the upper constraint |
The main reason we have an upper version constraint was due to earlier incompatibilities. We can certainly drop it now. |
Added additional commit removing the version constraint. Thanks all for feedback + quick response. |
Referencing other Google modules like terraform-google-modules/terraform-google-project-factory#505 Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
Referencing other Google modules like terraform-google-modules/terraform-google-project-factory#505 Signed-off-by: Yong Wen Chua <lawliet89@users.noreply.github.com>
This PR adds support for terraform 0.14.
This PR just bumps the version I haven't been able to test in my setup - I assume however it works as per terraform-google-modules/terraform-google-sql-db#165 (comment).