-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support terraform 0.14+ #165
Conversation
@morgante thoughts on this? This would prevent us from having to bump these each time and we can keep constraining the lower bounds as we include new features. |
I think it's reasonable to drop the upper version constraint. We can restore it in cases where we know the module to be incompatible but I'm fine with being permissive by default. |
Should I go ahead and drop the upper version constraint like in https://github.com/terraform-google-modules/terraform-google-project-factory/pull/505/files ? |
@pdecat Yes please do. |
Done. Note: some files have |
Likely they worked with any 0.12 version, this looks fine thanks! |
any plans for a release? |
This PR adds support for terraform 0.14.
Note: it is considered a "best practice" to not define upper limits for terraform core version in reusable modules:
See https://www.terraform.io/docs/configuration/version-constraints.html#terraform-core-and-provider-versions