Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support terraform 0.14+ #165

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Dec 3, 2020

This PR adds support for terraform 0.14.

Note: it is considered a "best practice" to not define upper limits for terraform core version in reusable modules:

Terraform Core and Provider Versions

Reusable modules should constrain only their minimum allowed versions of Terraform and providers, such as >= 0.12.0. This helps avoid known incompatibilities, while allowing the user of the module flexibility to upgrade to newer versions of Terraform without altering the module.

See https://www.terraform.io/docs/configuration/version-constraints.html#terraform-core-and-provider-versions

@bharathkkb
Copy link
Member

Reusable modules should constrain only their minimum allowed versions of Terraform and providers, such as >= 0.12.0. This helps avoid known incompatibilities, while allowing the user of the module flexibility to upgrade to newer versions of Terraform without altering the module.

@morgante thoughts on this? This would prevent us from having to bump these each time and we can keep constraining the lower bounds as we include new features.

@morgante
Copy link
Contributor

morgante commented Dec 3, 2020

I think it's reasonable to drop the upper version constraint. We can restore it in cases where we know the module to be incompatible but I'm fine with being permissive by default.

@pdecat
Copy link
Contributor Author

pdecat commented Dec 3, 2020

Should I go ahead and drop the upper version constraint like in https://github.com/terraform-google-modules/terraform-google-project-factory/pull/505/files ?

@pdecat pdecat changed the title Support terraform 0.14 Support terraform 0.14+ Dec 3, 2020
@morgante
Copy link
Contributor

morgante commented Dec 3, 2020

@pdecat Yes please do.

@pdecat
Copy link
Contributor Author

pdecat commented Dec 3, 2020

Done.

Note: some files have >= 0.12 instead of >= 0.12.6, is that normal?

@morgante
Copy link
Contributor

morgante commented Dec 3, 2020

Likely they worked with any 0.12 version, this looks fine thanks!

@bharathkkb bharathkkb merged commit e283340 into terraform-google-modules:master Dec 3, 2020
@pdecat pdecat deleted the tf014 branch December 3, 2020 19:33
@caarlos0
Copy link

caarlos0 commented Dec 8, 2020

any plans for a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants