Fix: Change default value of network_policy variable to false #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Thanks for the PR! 🚀 |
morgante
suggested changes
Feb 3, 2021
|
Thanks! Do you have any more information in the meantime on why the CI/CD pipeline is failing? Can't see the cloud build details. |
bharathkkb
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Hi @JeremyKeustersML6
We have an upcoming breaking release coming up that we can roll this into. Could you add this to the upgrade guide showing how users can continue to use netpol with 14.0? A diff like this should work.
|
Sure @bharathkkb ! Will push something tomorrow. |
|
I added some documentation @bharathkkb . Let me know if it's okay! |
|
@JeremyKeustersML6 Please resolve the linter errors ^^^ |
morgante
approved these changes
Feb 26, 2021
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…les#809) BREAKING CHANGE: The `network_policy` variable now defaults to `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #804.
The only thing I'm not sure about is whether or not the
network_policychecks are necessary in thestubintegration tests (stub_domains,stub_domains_private,stub_domains_upstream_nameservers).