-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataplane-v2 provisioning support #753
Add dataplane-v2 provisioning support #753
Conversation
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ryan-atkins
as-is, would need to set network_policy = false whenever desiring to use the "ADVANCED_DATAPATH" provider due to module currently setting CALICO as the default network_policy_provider
It makes sense to automatically set that for the user if they are explicitly enabling dataplanev2. We should also document this in the variable description. For implementation we would need to check if ADVANCED_DATAPATH
is set and use that to control the network_policy
behavior in places below.
disabled = ! var.network_policy |
cluster_network_policy = var.network_policy ? [{ |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
@bharathkkb, are you working on this already? If not would you feel like maybe doing some mentoring around it? I'd like to see it implemented but I'm still pretty new with Terraform and don't know much about this module. It looks like it's pretty close already but I may need some guidance around network policy. |
I'm not quite sure if
I would assume that with these settings it would automatically choose |
I think you might be incorrect as when I try to deploy a cluster using ADVANCED_DATAPATH and network policy true I get:
Also in the documentation here: https://cloud.google.com/kubernetes-engine/docs/how-to/dataplane-v2?hl=it
So perhaps it is possible to enable it after the fact given the warning here, but it seems it cannot be done on first deploy. |
…m-google-kubernetes-engine into feature/dataplane-v2-support
Sorry ignored this for awhile! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryan-atkins
Why is this so complicated? Wouldn't it make much more sense to extend |
@gw0 This was the simplest non-breaking fix, but we could probably re-evaluate interaction with |
…#753) * add datapath_provider var for beta clusters * incorporate datapath_provider option * update tests for datapath_provider beta cluster * example README var updates * remove network_policy var usage * finish docs updates Co-authored-by: ryan-atkins <>
Fixes #656
The datapath_provider was released in terraform-provider-google-beta v3.41.0
network_policy = false
whenever desiring to use the "ADVANCED_DATAPATH" provider due to module currently setting CALICO as the default network_policy_provider.Could use suggestions on how best to handle introducing this and better working with the network_policy config.