remove data google_client_config from all modules as it is no longer used within modules #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yashbhutwala
commented
Apr 24, 2021
•
yashbhutwala
commented
- Token is no longer used within scripts
- No need to store the auth token in tfstate twice. (Ideally, if possible, don't store at all, but currently kubernetes provider with this module works this way. Is there an alternate?)
…used within modules
yashbhutwala
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
morgante
approved these changes
Apr 29, 2021
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…nger used within modules (terraform-google-modules#875) * remove data google_client_config from all modules as it is no longer used within modules * remove all auth files marked by autogen * remove what I think is unnecessary dependencies on data field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.