Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up kubectl-wrapper and gcloud module version to add ability to impersonate service account #903

Merged
merged 7 commits into from
May 20, 2021
Merged

Bump up kubectl-wrapper and gcloud module version to add ability to impersonate service account #903

merged 7 commits into from
May 20, 2021

Conversation

yashbhutwala
Copy link
Contributor

@yashbhutwala yashbhutwala commented May 20, 2021 •
edited
Loading

Continuation of terraform-google-modules/terraform-google-gcloud#91. Resolves #874 and #879

NOTES:

  • In order to make this easier to review, I have separated the commits based on changes per module, i.e.: one for all the gke modules, one for workload identity module, one for asm module, one for k8s-operator-crd-support, etc.

@yashbhutwala yashbhutwala mentioned this pull request May 20, 2021
Merged
@comment-bot-dev
Copy link

comment-bot-dev commented May 20, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

morgante
morgante approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@morgante
Copy link
Contributor

Test failure is unrelated.

@morgante morgante merged commit fc43485 into terraform-google-modules:master May 20, 2021
@yashbhutwala
Copy link
Contributor Author

Thank you @morgante for the approval! Can you please create a point release with this PR?

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@yashbhutwala
fix: Add ability to impersonate service accounts in kubectl for all s…
879ee34 
…ubmodules (terraform-google-modules#903)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using service account impersonation for terraform invoking this module
3 participants
@yashbhutwala @comment-bot-dev @morgante