Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any way to specify a min_cpu_platform? #985

Closed
shermanericts opened this issue Aug 23, 2021 · 2 comments · Fixed by #1057
Closed

Is there any way to specify a min_cpu_platform? #985

shermanericts opened this issue Aug 23, 2021 · 2 comments · Fixed by #1057
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@shermanericts
Copy link

Hey there!
I'm looking for a way to set a minimum cpu platform, preferably at the node pool level, or secondly at a cluster level.

I noticed that the Terraform resource google_container_cluster has a min_cpu_platform in Beta.

I didn't see anything when going through this module.

Thanks in advance!
@morgante
Copy link
Contributor

Not currently, it would need to be added here.

Happy to review a PR.

@morgante morgante added enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work labels Aug 23, 2021
@shermanericts
Copy link
Author

thanks @morgante - i'll check it out.

This was referenced Nov 9, 2021
Closed
Closed
kudipudi added a commit to kudipudi/terraform-google-kubernetes-engine that referenced this issue Nov 9, 2021
@kudipudi
feat: Added support for specifying min_cpu_platform in node config - fix
9f48ab7 
 terraform-google-modules#985
@kudipudi kudipudi mentioned this issue Nov 9, 2021
Merged
morgante pushed a commit that referenced this issue Nov 12, 2021
@kudipudi @bharathkkb
feat: Added support for specifying min_cpu_platform in node config - … (
23b5243 
#1057)

* feat: Added support for specifying min_cpu_platform in node config - fix #985

* README: Added description for min_cpu_platform in node config

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@kudipudi @bharathkkb
feat: Added support for specifying min_cpu_platform in node config - … (
5ab322e 
terraform-google-modules#1057)

* feat: Added support for specifying min_cpu_platform in node config - fix terraform-google-modules#985

* README: Added description for min_cpu_platform in node config

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
2 participants
@morgante @shermanericts