Fix issue with regional cluster roll outs causing version skews #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefirstofthe300
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
adrienthebo
reviewed
Mar 19, 2019
thefirstofthe300
force-pushed
the
ds/fix-version-skews
branch
from
39b30d8
to
809d43d
Compare
adrienthebo
reviewed
Mar 19, 2019
thefirstofthe300
force-pushed
the
ds/fix-version-skews
branch
3 times, most recently
from
1b5cad5
to
7aa4893
Compare
aaron-lane
suggested changes
Mar 20, 2019
thefirstofthe300
force-pushed
the
ds/fix-version-skews
branch
2 times, most recently
from
a49278d
to
9c5dab5
Compare
Regional clusters are created using the newest version of GKE that is available across all zones in which the masters live. When a GKE version roll out occurs, the available versions across the zones can become skewed for zonal clusters with version x.y.z-gke.a being the only available zonal version in one zone but version x.y[+1].z[+1]-gke.a[+1] being the only zonal version available in another zone. The Terraform module only checks for the version available in the first zone returned by a call to the google_compute_zones data resource. Consequently, the module will fail to create a regional cluster during a roll out due to the version available in that zone not being available across all the zones for regional clusters.
thefirstofthe300
force-pushed
the
ds/fix-version-skews
branch
from
9c5dab5
to
1d73e9d
Compare
adrienthebo
reviewed
Mar 20, 2019
| @@ -24,6 +24,11 @@ provider "google" { | |||
| version = "~> 1.20" | |||
| } | |||
|
|
|||
| provider "google-beta" { | |||
| credentials = "${file(var.credentials_path)}" | |||
There was a problem hiding this comment.
Is it appropriate to pin the provider version here?
adrienthebo
reviewed
Mar 20, 2019
| @@ -24,6 +24,11 @@ provider "google" { | |||
| region = "${var.region}" | |||
| } | |||
|
|
|||
| provider "google-beta" { | |||
| credentials = "${file(var.credentials_path)}" | |||
There was a problem hiding this comment.
Is it appropriate to pin the provider version here?
adrienthebo
reviewed
Mar 20, 2019
| @@ -23,6 +23,11 @@ provider "google" { | |||
| region = "${var.region}" | |||
| } | |||
|
|
|||
| provider "google-beta" { | |||
| credentials = "${file(var.credentials_path)}" | |||
There was a problem hiding this comment.
Is it appropriate to pin the provider version here?
adrienthebo
reviewed
Mar 20, 2019
| @@ -24,6 +24,11 @@ provider "google" { | |||
| region = "${var.region}" | |||
| } | |||
|
|
|||
| provider "google-beta" { | |||
| credentials = "${file(var.credentials_path)}" | |||
| region = "${var.region}" | |||
There was a problem hiding this comment.
Is it appropriate to pin the provider version here?
adrienthebo
approved these changes
Mar 20, 2019
aaron-lane
approved these changes
Mar 20, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…/ds/fix-version-skews Fix issue with regional cluster roll outs causing version skews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regional clusters are created using the newest version of GKE that is
available across all zones in which the masters live. When a GKE version
roll out occurs, the available versions across the zones can become
skewed for zonal clusters with version x.y.z-gke.a being the only
available zonal version in one zone but version x.y[+1].z[+1]-gke.a[+1]
being the only zonal version available in another zone.
The Terraform module only checks for the version available in the first
zone returned by a call to the google_compute_zones data resource.
Consequently, the module will fail to create a regional cluster during a
roll out due to the version available in that zone not being available
across all the zones for regional clusters.