-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update TPG version constraints to 4.0 #1129
Changes from all commits
65aa00e
d988d3e
84f737c
fc4abaf
190ae7f
a493bc2
de86662
69fffa0
5c14247
93925ae
eb289be
2ce599a
a47d6e6
b722774
15eef37
21ed39a
f2d7f82
c687275
a304f6d
6b56495
b7f094f
df47f35
f9b7ec3
8ea9a16
6adaa60
5a9480a
cfeb0db
8a6809a
88f2ab8
c01a336
2d8e5eb
280cb8f
e83bfc3
616a0f7
3f9ebce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Upgrading to v18.0 | ||
|
||
The v18.0 release of *kubernetes-engine* is a backwards incompatible release. | ||
|
||
### Google Cloud Platform Provider upgrade | ||
The Terraform Kubernetes Engine Module now requires version 4.0 or higher of | ||
the Google Cloud Platform Provider. | ||
|
||
```diff | ||
terraform { | ||
required_providers { | ||
google = { | ||
source = "hashicorp/google" | ||
- version = "~> 3.0" | ||
+ version = "~> 4.0" | ||
} | ||
google-beta = { | ||
source = "hashicorp/google-beta" | ||
- version = "~> 3.0" | ||
+ version = "~> 4.0" | ||
} | ||
|
||
} | ||
} | ||
``` | ||
|
||
### Kubernetes Basic Authentication removed | ||
Basic authentication is deprecated and has been removed in GKE 1.19 and later. | ||
Owing to this, the `basic_auth_username` and `basic_auth_password` variables | ||
have been eliminated. | ||
|
||
```diff | ||
module "gke" { | ||
source = "terraform-google-modules/kubernetes-engine/google//modules/private-cluster" | ||
- version = "~> 17.0" | ||
+ version = "~> 18.0" | ||
|
||
- basic_auth_username = "admin" | ||
- basic_auth_password = "s3crets!" | ||
} | ||
``` | ||
|
||
### Acceptable values for node_metadata modified | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of requiring users to change this, I think we can provide a mapping at very low effort to ourselves. Could you add that? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated the doc in e83bfc3 to make this a recommendation instead, encouraging users to switch to values that are supported by the provider. |
||
It is recommended to update `node_metadata` variable to one of `GKE_METADATA`, | ||
`GCE_METADATA` or `UNSPECIFIED`. `GKE_METADATA` replaces the previous | ||
`GKE_METADATA_SERVER` value, `GCE_METADATA` should be used in place of | ||
`EXPOSE`, however old values continue to be supported for backwards compatibility. | ||
The `SECURE` option, previously deprecated, has now been removed. | ||
|
||
```diff | ||
module "gke" { | ||
source = "../../modules/safer-cluster" | ||
|
||
node_pools = [ | ||
{ | ||
|
||
- node_metadata = "GKE_METADATA_SERVER" | ||
+ node_metadata = "GKE_METADATA" | ||
} | ||
] | ||
} | ||
``` | ||
|
||
### node_pools_versions is now keyed by node-pool name | ||
The `node_pools_versions` output is now an object keyed by node pool name, | ||
rather than a list as previously. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for hashicorp/terraform-provider-google#10494. Long term fix maybe GoogleCloudPlatform/magic-modules#5526 but will need to validate.