-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for image streaming/GCFS #1174
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sasha-s
Can we add this to the nodepool variable docs https://github.com/terraform-google-modules/terraform-google-kubernetes-engine#node_pools-variable
@bharathkkb Anything I should add to the PR? |
thanks for taking care of this (I opened the original issue) - if you have the time, maybe we can also add it to the safer cluster variants? or I can also do that in a follow up |
@lauraseidler I will leave it upto @sasha-s, otherwise happy to accept a follow up too. |
I do not have access to the CI build, what is going on there? @bharathkkb could you please have a look? BTW, should it be
(instead of |
Ping. |
@sasha-s CI error looks like a flake- I have re triggered it.
Yeah we should switch that to each.value. Otherwise it will set the value for the first nodepool for all nodepools. |
Fixed the min_cpu_platform lookup in #1207 |
I just realised this is configuration on node pool level - so it will automatically also work for the safer clusters :) thanks for implementing! |
…1174) * propagate enable_gcfs * move changes to autogen * add enable_gcfs to docs
Fixes #1149