Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM module] Document ASM module data source workaround #1188

Closed
wants to merge 1 commit into from
Closed

[ASM module] Document ASM module data source workaround #1188

wants to merge 1 commit into from

Conversation

Monkeyanator
Copy link
Contributor

@Monkeyanator Monkeyanator commented Mar 25, 2022 •
edited

Documents workaround for #1181

morgante
morgante reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I think we should just fix the module. It would be faster/simpler than this.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@Monkeyanator
Copy link
Contributor Author

Documents workaround for #1181

Opened #1189, if that approach looks good will close this.

@bharathkkb
Copy link
Member

@morgante I am thinking it could be worth documenting this (without the workaround code) incase the user is using plain resources or a different module? The error surfaced is not very actionable.

@morgante
Copy link
Contributor

@morgante I am thinking it could be worth documenting this (without the workaround code) incase the user is using plain resources or a different module? The error surfaced is not very actionable.

Good point, but I think we should document it just by saying you must make the name dependent on the GKE cluster resource. I don't think we should use the locals hack as it's messy/unnecessary.

@Monkeyanator
Copy link
Contributor Author

Closing in favor of #1189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante left review comments

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Monkeyanator @comment-bot-dev @bharathkkb @morgante