Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin workload_identity example to k8s 1.23 #1315

Merged
merged 1 commit into from
Jul 9, 2022
Merged

chore: pin workload_identity example to k8s 1.23 #1315

merged 1 commit into from
Jul 9, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Jul 8, 2022

@apeabody apeabody changed the title fix: extend timeout for kubernetes_service_account fix: pin workload_identity example to k8s 1.21 Jul 8, 2022
@apeabody apeabody changed the title fix: pin workload_identity example to k8s 1.21 fix: pin workload_identity example to k8s 1.23 Jul 8, 2022
@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody marked this pull request as ready for review July 8, 2022 20:44
@apeabody apeabody requested review from a team, Jberlinsky and bharathkkb as code owners July 8, 2022 20:44
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @apeabody

@bharathkkb bharathkkb changed the title fix: pin workload_identity example to k8s 1.23 chore: pin workload_identity example to k8s 1.23 Jul 9, 2022
@bharathkkb
Copy link
Member

Marking it as chore: since this mainly affects the example.

@bharathkkb bharathkkb merged commit 59ca09e into terraform-google-modules:master Jul 9, 2022
@liggitt
Copy link
Contributor

liggitt commented Mar 25, 2023

can this be reverted? hashicorp/terraform-provider-kubernetes#1724 was addressed in v2.13.0 and k8s 1.24 is now the default version in Stable channel (https://cloud.google.com/kubernetes-engine/docs/release-schedule)

liggitt added a commit to liggitt/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2023
liggitt added a commit to liggitt/terraform-google-kubernetes-engine that referenced this pull request Mar 25, 2023
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants