-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: promote notification config & dns to ga #1327
Merged
bharathkkb
merged 3 commits into
terraform-google-modules:master
from
ericyz:feat/gke_notification
Aug 9, 2022
Merged
feat!: promote notification config & dns to ga #1327
bharathkkb
merged 3 commits into
terraform-google-modules:master
from
ericyz:feat/gke_notification
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd05ea2
to
c0fa535
Compare
Please review at your convenience. Much appreaciated! |
bharathkkb
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ericyz
We will add this to our next breaking release since there is a provider bump.
rebase master and resolve the conflicts |
…oogle-kubernetes-engine into feat/gke_notification
c3b1e21
to
f5c9703
Compare
@ericyz |
bharathkkb
approved these changes
Aug 9, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…les#1327) * feat: support notification config &dns in ga * feat: support notification config &dns in ga
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.