Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add module_depends_on to workload-identity #1341

Merged
merged 3 commits into from
Aug 17, 2022
Merged

feat: add module_depends_on to workload-identity #1341

merged 3 commits into from
Aug 17, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Aug 1, 2022 •
edited

@apeabody apeabody mentioned this pull request Aug 1, 2022
Open
@apeabody
Copy link
Contributor Author

apeabody commented Aug 2, 2022

Requires #1342

@apeabody apeabody marked this pull request as ready for review August 2, 2022 23:07
@apeabody apeabody requested review from a team, Jberlinsky and bharathkkb as code owners August 2, 2022 23:07
bharathkkb
bharathkkb approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although for ordering you can rely on the fact that the cluster name is computed.

terraform-google-kubernetes-engine/outputs.tf

Line 26 in 600dcb7

value = local.cluster_name_computed

modules/workload-identity/variables.tf Outdated Show resolved Hide resolved
@bharathkkb
Copy link
Member

Also @apeabody I believe terraform-google-modules/terraform-google-gcloud#82 is for supporting the native depends_on for gcloud which wont be fixed by this.

@apeabody
Copy link
Contributor Author

apeabody commented Aug 3, 2022 •
edited

Also @apeabody I believe terraform-google-modules/terraform-google-gcloud#82 is for supporting the native depends_on for gcloud which wont be fixed by this.

Thanks @bharathkkb - Yes, this and #1323 were for an add-on later in the thread terraform-google-modules/terraform-google-gcloud#82 (comment). I'll change the PR comment to leave the overall issue open.

@apeabody
Copy link
Contributor Author

apeabody commented Aug 5, 2022

Holding for discussion on terraform-google-modules/terraform-google-gcloud#123

@apeabody
Copy link
Contributor Author

Enhanced docs per terraform-google-modules/terraform-google-gcloud#123

@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody merged commit a6dce1a into terraform-google-modules:master Aug 17, 2022
@apeabody apeabody deleted the ap-patch-3 branch August 17, 2022 22:41
@release-please release-please bot mentioned this pull request Aug 17, 2022
Merged
@DP19 DP19 mentioned this pull request Aug 20, 2022
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody @bharathkkb
feat: add module_depends_on to workload-identity (terraform-google-mo…
bf4484b 
…dules#1341)

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeabody @bharathkkb @comment-bot-dev