-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add module_depends_on to workload-identity #1341
feat: add module_depends_on to workload-identity #1341
Conversation
Requires #1342 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although for ordering you can rely on the fact that the cluster name is computed.
value = local.cluster_name_computed |
Also @apeabody I believe terraform-google-modules/terraform-google-gcloud#82 is for supporting the native |
Thanks @bharathkkb - Yes, this and #1323 were for an add-on later in the thread terraform-google-modules/terraform-google-gcloud#82 (comment). I'll change the PR comment to leave the overall issue open. |
Holding for discussion on terraform-google-modules/terraform-google-gcloud#123 |
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Enhanced docs per terraform-google-modules/terraform-google-gcloud#123 |
@apeabody |
…dules#1341) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Per terraform-google-modules/terraform-google-gcloud#82