Truncating Membership ID when greater than 63 character #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaybathija-github
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
bharathkkb
reviewed
Oct 18, 2022
|
@akshaybathija-github |
bharathkkb
approved these changes
Oct 19, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…raform-google-modules#1429) * Truncating Membership ID when greater than 63 character * Correcting Linting * Modifying If Logic and Adding Trim Suffix Co-authored-by: Akshay Bathija <akshaybathija@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the Cluster Membership ID to be truncated in case of >63 character based on API limits
API Limit Reference : https://cloud.google.com/anthos/fleet-management/docs/reference/rest/v1/projects.locations.memberships
Earlier the Formula for Calculation was : ${var.project_id}-${var.location}-${var.cluster_name}
Now in case this exceed 63 character it will trim the ending to fit 63 characters