fixed GitHub Issue #1445 | location_policy permadrifting #1448
Conversation
QBYMKPI
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cluster.tf
Outdated
| @@ -324,8 +324,9 @@ resource "google_container_node_pool" "pools" { | |||
| dynamic "autoscaling" { | |||
| for_each = lookup(each.value, "autoscaling", true) ? [each.value] : [] | |||
| content { | |||
| min_node_count = lookup(autoscaling.value, "min_count", 1) | |||
| max_node_count = lookup(autoscaling.value, "max_count", 100) | |||
| location_policy = "BALANCED" | |||
There was a problem hiding this comment.
We should make the change in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/autogen and run make build. It would also be good to expose as an option to make it user configurable.
|
need this fix too 👍 |
Co-authored-by: Laurent Raufaste <analogue@glop.org>
|
The cla is not working for me and I don't know why the terraform-google-kubernetes-engine-int-trigger is not working. |
|
I'm not sure but I think the location_policy is ANY when it's a spot instance and BALANCED otherwise :
|
There was a problem hiding this comment.
@QBYMKPI CLA seems to be complaining about mkpi@QBY-01.2svxuh0oexkexj2mkebn452anh.ax.internal.cloudapp.net as an email in one of commits which does not seem to have a CLA. You can also just rewrite and force push.
@nvanheuverzwijn also seems to be correct, looking at https://cloud.google.com/kubernetes-engine/docs/concepts/spot-vms#default_policy we should set default to ANY if spot is selected.
|
@QBYMKPI |
|
Is someone with a valid CLA able to make this PR correctly? My setup won't allow me it. |
done here #1452 |
|
fixed by #1452 |
Hello devs,
we had the issue too with the GKE Module.
This is a workaround for the issue above.
Thank you.