Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: update variant - recreate node pools on max_pods_per_node or pod_range change #1464

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Fix: update variant - recreate node pools on max_pods_per_node or pod_range change #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
175b357
fix: add missing max_pods_per_node & pod_range keepers for update var…
splichy Nov 16, 2022
da270ea
max_pods_per_node & pod_range keepers autogen
splichy Nov 16, 2022
ba3d94a
Merge branch 'master' into fix/update_variant_recreate_node_pools
splichy Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions autogen/main/cluster.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,9 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"machine_type",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
Expand All @@ -510,8 +512,9 @@ locals {
}

# This keepers list is based on the terraform google provider schemaNodeConfig
# resources where "ForceNew" is "true". schemaNodeConfig can be found in node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/master/google/node_config.go#L22
# resources where "ForceNew" is "true". schemaNodeConfig can be found in resource_container_node_pool.go at
# https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_container_node_pool.go and node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/main/google/node_config.go
resource "random_id" "name" {
for_each = merge(local.node_pools, local.windows_node_pools)
byte_length = 2
Expand Down
7 changes: 5 additions & 2 deletions modules/beta-private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,9 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"machine_type",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
Expand All @@ -448,8 +450,9 @@ locals {
}

# This keepers list is based on the terraform google provider schemaNodeConfig
# resources where "ForceNew" is "true". schemaNodeConfig can be found in node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/master/google/node_config.go#L22
# resources where "ForceNew" is "true". schemaNodeConfig can be found in resource_container_node_pool.go at
# https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_container_node_pool.go and node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/main/google/node_config.go
resource "random_id" "name" {
for_each = merge(local.node_pools, local.windows_node_pools)
byte_length = 2
Expand Down
7 changes: 5 additions & 2 deletions modules/beta-public-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"machine_type",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
Expand All @@ -429,8 +431,9 @@ locals {
}

# This keepers list is based on the terraform google provider schemaNodeConfig
# resources where "ForceNew" is "true". schemaNodeConfig can be found in node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/master/google/node_config.go#L22
# resources where "ForceNew" is "true". schemaNodeConfig can be found in resource_container_node_pool.go at
# https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_container_node_pool.go and node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/main/google/node_config.go
resource "random_id" "name" {
for_each = merge(local.node_pools, local.windows_node_pools)
byte_length = 2
Expand Down
7 changes: 5 additions & 2 deletions modules/private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,9 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"machine_type",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
Expand All @@ -334,8 +336,9 @@ locals {
}

# This keepers list is based on the terraform google provider schemaNodeConfig
# resources where "ForceNew" is "true". schemaNodeConfig can be found in node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/master/google/node_config.go#L22
# resources where "ForceNew" is "true". schemaNodeConfig can be found in resource_container_node_pool.go at
# https://github.com/hashicorp/terraform-provider-google/blob/main/google/resource_container_node_pool.go and node_config.go at
# https://github.com/terraform-providers/terraform-provider-google/blob/main/google/node_config.go
resource "random_id" "name" {
for_each = merge(local.node_pools, local.windows_node_pools)
byte_length = 2
Expand Down